Skip to content

Suppress MIR comments on unit type constants #75730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Suppress MIR comments on unit type constants #75730

wants to merge 3 commits into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 20, 2020 •
edited
Loading

Should I merge this PR with #75670 ?

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Aug 20, 2020

yea I think merging these is totally fine, we can prioritize the merged version

@tesuji
Copy link
Contributor Author

tesuji commented Aug 20, 2020

Alright, will merge them together.

@tesuji tesuji closed this Aug 20, 2020
@tesuji tesuji deleted the mir-suppress-unit-cmts branch August 20, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesuji @oli-obk @rust-highfive